src/sbbs3 main.cpp 1.703 1.704
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28048

Modified Files:
main.cpp
Log Message:
Tabs are stupid.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.704 1.705
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30934

Modified Files:
main.cpp
Log Message:
Check the terminate_output_thread flag after acquiring the ssh_muex.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.705 1.706
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Added function names to SSH error messages so we can better tell where
these errors are coming from.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.706 1.707
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4421

Modified Files:
main.cpp
Log Message:
Create yet-another GCES macro (GCESSTR) to log the output_thread instance description string ('node') in SSH-related log messages (e.g. errors) from the output_thread: No more "Node 0" log entries from here.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.709 1.710
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Apparent fix for SSH cryptlib session leak (leading to eventual
'Resource/space exhausted' errors in TLS and SSH:
The wrong ssh_session is being passed to cryptDestroySession() in sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession() fails (returns -1, bad param) thus leaving the actual
ssh_session never destroyed (leaked).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.711 1.712
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Fix typo in previous commit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.712 1.713
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4929

Modified Files:
main.cpp
Log Message:
Some log output updates, mainly adding errno string-representation where missing, but also now logging when renaming (or failing to rename) bad
received .REP packet files.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.713 1.714
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21015

Modified Files:
main.cpp
Log Message:
Fix race-condition causing SSH errors:
Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
... from output_thread

The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session to 0 (the "parameter 1" value used in the cryptlib function calls in output_thread) but was doing this without owning the ssh_mutex, so the output_thread had a race condition where it would check ssh_mode=true and
then use grab the ssh_mutex and use ssh_session in a few cryptlib function calls. The fix for the bbs_thread() to grab the ssh_mutex before setting ssh_mode to false and ssh_session to 0 and have the output_thread() re-check the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
functions if ssh_mode was set to false while waiting for the mutex.

The cause would have been more obvious if the various cryptlib error/log messages contained the cryptlib session ID value (which was 0 in this case).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.714 1.715
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Fix more race conditions which cause Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... from output_thread



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.715 1.716
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Fix yet another race condition that could cause:
Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ...
from output_thread
Don't set ssh_mode=true until the ssh_session has been created successfully.

Also added some more debug output with regards to Cryptlib session number.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.716 1.717
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26275

Modified Files:
main.cpp
Log Message:
Added protocol (e.g. Telnet, Rlogin, or SSH) to more log messages
(e.g. warnings and errors).
Also, stripped trailing white-space from many lines (editor setting).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.719 1.720
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6643

Modified Files:
main.cpp
Log Message:
Fix problem with socket-I/O external programs executed while the client
using SSH: the output from the program (file transfer driver, door game)
would reach the SSH client, but input from the client (or user) would not
reach the external program:
passthru_output_thread() - responsible for SSH input from the client/user
to be sent to a "raw" pass-through socket used by the external program,
had a reversed logic bug added around rev 1.686.
Problem was introduced as part of the cryptlib update/SSH overhaul of
early 2018. Thanks to Thumper @ THEWASTE for the bug report!



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.721 1.722
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19028

Modified Files:
main.cpp
Log Message:
More eprintf() to sbbs->lputs/lprintf() replacements.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.722 1.723
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10420

Modified Files:
main.cpp
Log Message:
Make sure the current user number is 0 when terminating the event thread
or else we may end up with user names in log msgs that don't apply.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.723 1.724
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12956

Modified Files:
main.cpp
Log Message:
More useron number clearing after timed event segments.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.724 1.725
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14954

Modified Files:
main.cpp
Log Message:
Strip control codes from strings logged with sbbs_t::lputs().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.725 1.726
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2227

Modified Files:
main.cpp
Log Message:
More eprintf() to sbbs->lprintf() conversion.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.726 1.727
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8199

Modified Files:
main.cpp
Log Message:
Fix conditions where event log messages could still be sent to the terminal server log output/window.
Also added comment about an observed exception upon shutdown with regards to the node_threads_running counter (protected int) being accessed after destruction.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.727 1.728
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4756

Modified Files:
main.cpp
Log Message:
Log the execution result (error-level/return-value) of more events and
QWKnet call-outs. Hopefully help debug Mortifis' problem with QWKnet
call-outs.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.728 1.729
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7009

Modified Files:
main.cpp
Log Message:
Log errors when failing to delete semaphore (e.g. *.now) and other files.
Fixed some funny typos in comments.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.729 1.730
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13955

Modified Files:
main.cpp
Log Message:
Enclose user's name/alias in < > in log output, this makes the name clearly separate from the log text and is consistent with the mail server log
output.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.730 1.731
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14540

Modified Files:
main.cpp
Log Message:
Zero-initialize the subscan array.
Lock the mail base while backing it up as part of the daily maintenance.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.732 1.733
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Fixed some gcc warnings:
format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has
type ‘unsigned int’



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.733 1.734
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Deal with gcc warnings that crop up because sizeof() is an unsigned long sometimes and sometimes it's an unsigned int.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.735 1.736
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19254

Modified Files:
main.cpp
Log Message:
When logging event-thread error messages, include the "evnt " prefix before
the string (which starts with the event internal code).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.738 1.739
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26989

Modified Files:
main.cpp
Log Message:
Cosmetic fixes to timed event logging (the event code part of the log messages)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.739 1.740
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9095

Modified Files:
main.cpp
Log Message:
Change the "unpack REP" log messgae prefix to "unpackREP" instead of "unQWK".


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.749 1.750
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16111

Modified Files:
main.cpp
Log Message:
New cryptlib uses 345 not 3450.
*sigh*




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.757 1.758
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22730

Modified Files:
main.cpp
Log Message:
Accept and store the "Internet host number" portion of the telnet
TERMINAL LOCATION NUMBER (RFC 946) in sbbs_t::telnet_location.

Some (older?) versions of fTelnet request to send this option to the BBS to share the real IP address of the client. Accept this option (when using
"format 0") and store the first 32-bits (an IPv4 address) in the telnet location storage / caller-ID information. The same place the telnet
SEND LOCATION value is stored if received.

Now, we're not requesting this option (e.g. with a Telnet "DO" command), but fTelnet doesn't need that: It offers to send it, so we accept.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.758 1.759
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17377

Modified Files:
main.cpp
Log Message:
Log the length of received telnet sub-negotiation commands (in bytes).
Only retain the last (most recent) 10 data/<id>.qwk.*.bad files and data/file/<user-num>.rep.*.bad files.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.760 1.761
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12091

Modified Files:
main.cpp
Log Message:
We need to expand telnet IACs contained in passthru socket data received from external programs (when in Telnet mode).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.763 1.764
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
A couple of passthrough socket fixes:
1. when de-activating the passthru socket, give the passthru_thread some
cycles to copy any remaining socket data into the outbuf before we let
the node_thread continue on and spew its own data into the outbuf.
This fixes the problem of final messages of a file transfer protocol
being intermixed with BBS data (prompts, menus, and such) and causing
file download finalization issues.
2. Don't read from the passthru socket until there is enough room in the
outbuf for the maximum possible telnet-expanded read size. This fixes
streaming download protocol (ZMODEM and YMODEM-G) errors.

Also, for good measure, check the passthru_socket for writability before send()ing on it and log a warning if it's ever not writable.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.765 1.766
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27823

Modified Files:
main.cpp
Log Message:
Re-enable socket optoins and blocking configuration for the client_socket_dup when de-activating the passthru_socket.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.766 1.767
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4564

Modified Files:
main.cpp
Log Message:
passthru_socket():
Always call recv() when select() says the passthru_socket is readable, even
if the outbuf is full. This resolves an issue where the disconnection of the passthru_socket would not be detected if the outbuf was full (e.g. the output_thread stopped running).
Also, check if RingBufWrite() returns a short-write count and log the values (actual versus expected write byte count).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.767 1.768
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14985

Modified Files:
main.cpp
Log Message:
Log value of 'writable' in "could not write to passthru socket" log msg.
May help determine if the socket is disconnected or just not writable.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.768 1.769
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Resolve a couple harmless GCC warnings.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.769 1.770
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28680

Modified Files:
main.cpp
Log Message:
When the passthru_thread terminates, set passthru_socket_active to false.
This resolves the issue where if an external program closes the client_socket_dup, the passthru_thread can't write to the passthru_socket,
so it terminates itself - by definition, deactivating the passthru_socket, but it didn't clear passthru_socket_active, so the input_thread would keep trying to write to it rather than sending the input from the user to the BBS.

Also, terminate the passthru_thread (without any special log message) when sbbs->online is non-zero.

Also overhauled a lot of the passthru-related log messages. Passthru ain't just for SSH anymore.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.770 1.771
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21353

Modified Files:
main.cpp
Log Message:
Leave room for telnet IAC expansion (as much as 100%) in the outbuf.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.771 1.772
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12576

Modified Files:
main.cpp
Log Message:
Eliminate call to inet_ntop() which is apparently not present in WinXP:
The procedure entry point inet_ntop could not be located in dynamic link library ws2_32.dll



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

El 28/8/19 a las 23:23, rswindell escribió:

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.

---

i notice that have several *.bad packets at my data dir.


-rw------- 1 root root 6807 ago 16 03:47 VERT.qwk.5d5a512f.bad
-rw------- 1 root root 7898 ago 13 19:47 VERT.qwk.5d5a5944.bad
-rw------- 1 root root 7245 ago 14 14:47 VERT.qwk.5d5a59bc.bad

i rename to vert.qwk to reprocess it, and say that all message are dupe.
Then, i think that was process and import messages fine.

is this commit related to this issue?


Aug 29 10:24:45 localhost synchronet: evnt Inbound QWK Packet detected: /sbbs/data/VERT.qwk
Aug 29 10:24:45 localhost synchronet: evnt QNET Executing external:
unzip -o -j /sbbs/data/VERT.qwk * -d /sbbs/temp/event/
Aug 29 10:24:45 localhost synchronet: evnt QNET Reading /sbbs/temp/event/HEADERS.DAT
Aug 29 10:24:45 localhost synchronet: evnt QNET Reading /sbbs/temp/event/VOTING.DAT
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK Network Packet: /sbbs/data/VERT.qwk
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Discussion
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564377.6017.sync@vert.synchro.net> found in message #36400
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message #36401
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message #36401
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564039.40573.dove_sync@digitaldistortionbbs.com> found in message #36402
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D5633E8.3542.dove-syncdisc@bbs.leenooks.net> found in
message #36403
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564ECC.6022.sync@vert.synchro.net> found in message #36404
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Programming (C/C++ and CVS)
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D56516D.39346.syncprog@cvsuser> found in message #21047
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Data
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564BFC.177089.syncdata@vert.synchro.net> found in message
#13539
Aug 29 10:24:45 localhost synchronet: evnt Finished Importing QWK
Network Packet from VERT: (0 msgs) in 1 seconds (0 msgs/sec), 1 errors,
8 dupes
Aug 29 10:24:45 localhost synchronet: evnt QNET /sbbs/data/VERT.qwk
renamed to /sbbs/data/VERT.qwk.5d67d21d.bad
Aug 29 10:24:45 localhost synchronet: evnt QNET !ERROR 2 (No such file
or directory) in main.cpp line 2876 (event_thread) removing "/sbbs/data/VERT.qwk" access=0



thanks!!

---
þ Synchronet þ Dock Sud BBS TLD 24 HS - http://bbs.docksud.com.ar - telnet://bbs.docksud.com.ar

Re: Re: src/sbbs3/main.cpp
By: Ragnarok to rswindell on Thu Aug 29 2019 11:07 am

El 28/8/19 a las 23:23, rswindell escribió:

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.

---

i notice that have several *.bad packets at my data dir.

-rw------- 1 root root 6807 ago 16 03:47 VERT.qwk.5d5a512f.bad -rw------- 1 root root 7898 ago 13 19:47 VERT.qwk.5d5a5944.bad -rw------- 1 root root 7245 ago 14 14:47 VERT.qwk.5d5a59bc.bad

i rename to vert.qwk to reprocess it, and say that all message are dupe. Then, i think that was process and import messages fine.

is this commit related to this issue?

The commit fixes this error:

Aug 29 10:24:45 localhost synchronet: evnt QNET !ERROR 2 (No such file
or directory) in main.cpp line 2876 (event_thread) removing "/sbbs/data/VERT.qwk" access=0

digital man

This Is Spinal Tap quote #37:
David St. Hubbins: We are Spinal Tap from the UK - you must be the USA!
Norco, CA WX: 92.1øF, 42.0% humidity, 4 mph NE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

i enable debug:, the "QWK vote failure, offset 6144 in
/sbbs/data/VERT.qwk" appear:


Aug 29 23:54:29 localhost synchronet: evnt Inbound QWK Packet detected: /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt QNET Executing external:
unzip -o -j /sbbs/data/VERT.qwk * -d /sbbs/temp/event/
Aug 29 23:54:29 localhost synchronet: evnt QNET Reading /sbbs/temp/event/HEADERS.DAT
Aug 29 23:54:29 localhost synchronet: evnt QNET Reading /sbbs/temp/event/VOTING.DAT
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK Network Packet: /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Discussion
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564377.6017.sync@vert.synchro.net> found in message #36400
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message
#36401
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message
#36401
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564039.40573.dove_sync@digitaldistortionbbs.com> found in message
#36402
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D5633E8.3542.dove-syncdisc@bbs.leenooks.net> found in
message #364
03
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564ECC.6022.sync@vert.synchro.net> found in message #36404
Aug 29 23:54:29 localhost synchronet: evnt QNET Duplicate vote-msg from VERT Aug 29 23:54:29 localhost synchronet: evnt QNET QWK vote failure, offset
6144 in /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Programming (C/C++ and CVS)
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D56516D.39346.syncprog@cvsuser> found in message #21047
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Data
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564BFC.177089.syncdata@vert.synchro.net> found in message
#13539
Aug 29 23:54:29 localhost synchronet: evnt Finished Importing QWK
Network Packet from VERT: (0 msgs) in 1 seconds (0 msgs/sec), 1 errors,
8 dupes
Aug 29 23:54:29 localhost synchronet: evnt QNET /sbbs/data/VERT.qwk
renamed to /sbbs/data/VERT.qwk.5d688fe5.bad

---
þ Synchronet þ Dock Sud BBS TLD 24 HS - http://bbs.docksud.com.ar - telnet://bbs.docksud.com.ar

src/sbbs3 main.cpp 1.773 1.774
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22798

Modified Files:
main.cpp
Log Message:
Log (debug-level) interesting sizeof() values during initialization, debug-builds only.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.774 1.775
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15235

Modified Files:
main.cpp
Log Message:
Received-telnet command improvements:
- If a telnet command was received in multiple packets, the memcpy optimization
in telnet_interpret() would skip/drop all bytes in the subsequent pkt payload
before an IAC char. Don't optimize when in the middle of a telnet command.
- If a received telnet command exceeds the telnet_cmd buffer, reset the
received telnet_cmdlen and log a warning-level message
- If a telnet sub-negotiation END command is received as the beginning of a
new telnet command, log a warning-level message and reset the telnet_cmdlen.

This fixes the occasional problem observed when using fTelnet and its sending the "SEND-LOCATION" sub-neg command split between 2 TCP packets. Only
part of the first packet would be used as the location data and the rest processed as input from the users (e.g. as the Login: prompt). Thanks, Ree!


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.775 1.776
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18524

Modified Files:
main.cpp
Log Message:
This change goes with the previous commit to scfglib2.c (with no commit msg): Address problem reported by Mark Lewis:
If a timed event is configured to both run "exclusively" and on "Any" node, then any nodes in use at the time of the event would get their status changed to waiting-for-connection (WFC) and it could actually become possible for 2 clients to be using the same node number.
So, when loading the configuration, turn off the "exclusive" flag if the event's node is set to "Any" (0).
Just for completeness, fix the actual bug (introduced in main.cpp 1.744) too.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.777 1.778
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10703

Modified Files:
main.cpp
Log Message:
Fix feature added in rev 1.759 (wrong path argument to delfiles):
Only retain the last (most recent) 10 data/<id>.qwk.*.bad files and data/file/<user-num>.rep.*.bad files.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.778 1.779
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12537

Modified Files:
main.cpp
Log Message:
The log msg "passthru socket listening on port n" was always wrong
(said port 0) since the port had not been bound yet.
So fix the display order of that msg (after listen() is called)
and lower the log level to debug.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.790 1.791
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13583

Modified Files:
main.cpp
Log Message:
Don't display full path (just the filename) of errored JS file to user.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/b105d77749607d5bc8dacc99
Modified Files:
src/sbbs3/main.cpp
Log Message:
Lower log level of the "Perhaps node is already runnnig" log msg from ERR to WARN

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/8bf25ec78bdcf404e0ddab27
Modified Files:
src/sbbs3/main.cpp
Log Message:
Lower the SSH-related log message severities to WARNING for SSH connections

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/9bf4b7bba19d951f3ca48c96
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't send telnet commands to spy sockets

send_telnet_cmd() now sends telnet commands/replies directly to the client socket. This avoid the entire output_thread() teeing of sent data to spy sockets/buffers (which may not be Telnet at all).

There are some concerns with this change:
- if client_socket isn't writable, will sendsocket() block?
- if output_thread is sending on the same socket, are our 2/3-byte telnet
commands going to have other output data interleaved within? (seems very
unlikely)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbdb2b494c85d24a7b3b887b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Move the "connect" spy message to where the hostname and IP address are known

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec6d7e3edf557779be7e54cd
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't count guest logins as authenticated connections...

When enforcing the MaxConcurrentConnections limit, don't count connections for user's with blank passwords (i.e. Guest) as authenticated.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/3a19853b763f35a22ece717c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Address 32-bit GCC warning about printf format

'%lu' expects argument of type 'long unsigned int', but argument 5 has type 'off_t

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/bd78d5c5725843afc6659822
Modified Files:
src/sbbs3/main.cpp
Log Message:
Add timestamp of node.log file to crash.log

When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548
Modified Files:
src/sbbs3/main.cpp
Log Message:
Ooops, forgot to make btox static

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/db690fadea6237739f73825c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Improve btox() so that it doesnt lead to any buffer overruns

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/main.cpp
By: Deon George to Git commit to sbbs/master on Sun Nov 22 2020 12:35 am

https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548 Modified Files:
src/sbbs3/main.cpp
Log Message:
Ooops, forgot to make btox static

Oops, I forgot to squash this giant merge. <grimmace>
--
digital man

Rush quote #64:
He's cleaning up his systems to keep his nature pure .. New World Man
Norco, CA WX: 75.9øF, 29.0% humidity, 6 mph NNE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/82d3ae6e61d8876d35444bdf
Modified Files:
src/sbbs3/main.cpp
Log Message:
Load/keep/refresh each node's configuration in memory.

Previously, all nodes shared the same copy of the configuration in memory. This prevented any node from seeing an updated configuration until all nodes were offline or waiting for connection and could be recycled. Now, no recycling of the server is needed for a node to load a new config. A node in-use *still* cannot reload configuration until the user disconnects, but all you have to do is logon to another unused node and you (or that user) will get an updated configuration. Bots or server recycling problems will no longer prevent the sysop or user from getting a current configuration when connecting to any node.

This is one of those instances of giving the sysop what he wants rather than what he asked for. I should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/827063bb1d4343e145a85ffa
Modified Files:
src/sbbs3/main.cpp
Log Message:
Copy event last-run info from global config into node config

Fixes issue introduced in last commit to this file (the each-node-has-its-own-config-in-memory enhancement) that would prevent users from logging in because their time was reduced for an upcoming event that had already run. The change assumes the event thread is running (its the thing that reads the event last-run info from time.dab). Thanks to mlong for the report.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/07bd3442362ada96e99a4294
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fallback to the "first node" configuration

If a node's configuration can't be loaded (e.g. nodeX/node.cnf is missing), fall-back and load the "first node" (e.g. Node1) configuration. On recent *nix installs (since the migration to Git), the node2+/node.cnf files were not copied/created, so let's solve that soon-to-be-FAQ now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/656bdb8fe79786b94f7dc5ac
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning when falling-back the loaded node configuration.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/main.cpp
By: Rob Swindell to Git commit to main/sbbs/master on Sun Nov 29 2020 12:31 am

another unused node and you (or that user) will get an updated configuration. Bots or server recycling
problems will no longer prevent the sysop or user from getting a current configuration when connecting
to any node.

This is one of those instances of giving the sysop what he wants rather than what he asked for. I
should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

This is freaking awesome. Thanks DM!

|01bobbobbobbob|09bob|03bob|11bob|03bob|09bob|01bobbobbob |01robrobrobrob|09rob|03rob|11rob|03rob|09rob|01robrobrob
|07

---
þ Synchronet þ Halls of Valhalla =San=Francisco= Happy Holidays

https://gitlab.synchro.net/main/sbbs/-/commit/d9ea54258ab2a39b3e71bdcf
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't create a JS "client" object for timed events

There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0d8ea19e309c6afd80a587c8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Create node#/client.ini for each node client connection

Paves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5e46cb0f6cc44b2176c97b0f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Additional/optional 'mode' argument to global prompt() method

Defaults to K_EDIT.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3202b477e52faa34e6fa5666
Modified Files:
src/sbbs3/main.cpp
Log Message:
Attempt to resolve "!ERROR 11 receiving from socket" reported by plt

<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into keybuf: 4E (N)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external: /sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet External X/Y/ZMODEM v3.0 master/23b741a1c Copyright Rob Swindell
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped by receiver
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting Transfer (Sending ZABORT)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from socket 14
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated (received 365 bytes in 35 blocks)

Not sure why this isn't happening for other sysops - perhaps plt was spying on the node?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4a705a4667fea6e699d7965a
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log local address in passthru connection failure

Altere reported via IRC:
!ERROR -1 (113) connecting to passthru socket

It might be helpful to know the address the passthru socket is bound to and the connection is being attempted on, so log that with the error.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/54de9ce32a60a3ec38fcd41d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix the printf format for the "ERROR ... connecting to passthru socket"

Was passing the address string twice, so the port appeared as an invalid number.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net