src/sbbs3 sbbsecho.c 3.73 3.74
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv445

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs) if it didn't already exist.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.74 3.75
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20684

Modified Files:
sbbsecho.c
Log Message:
Some status string (e.g. "Loading user names...") were being sent to stderr instead of stdout.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.75 3.76
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log an error if ftouch() fails to create the outbound sem file.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.76 3.77
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Use GCC-assisted printf-style format/arg checking to find and fix instances
of lprintf() misuse.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.77 3.78
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1786

Modified Files:
sbbsecho.c
Log Message:
Attempt to address GCC v7 warnings raised by Nelgin:
warning: format not a string literal and no format arguments [-Wformat-security]


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.78 3.79
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18475

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail included an "old-style" (not MIME-encoded) file attachment (where the file path is in the subject and the FILEATTACH aux-attribute flag is set), the corresponding netmail attribute flag would not be set in the stored msg (*.msg) file. Also simplified the create_netmail() function prototype/usage, removing the "file_attached" argument (use the hdr.auxattr instead).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.79 3.80
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
write_flofile(): if the 'infile' path contains a drive letter prefix
(e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
to forward-slashes (for all OSes). This resolves an issue of sending a
netmail file-attachment that was created on a Windows/MS-DOS type system
and then scanned/exported on a *nix system. The FTN "stored message"
convention is to have the full path of the attached file in the message subject.

Hopefully nobody wants to use outbound directory names beginning with "x:"
on *nix. :-)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.80 3.81
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19737

Modified Files:
sbbsecho.c
Log Message:
If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in length, just delete it (don't rename to *.?_?).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.81 3.82
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32044

Modified Files:
sbbsecho.c
Log Message:
When exporting msgs that came from an FTN (e.g. during a rescan), don't convert existing tear/origin lines and don't add a new origin line.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.82 3.83
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2537

Modified Files:
sbbsecho.c
Log Message:
Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan (apparently this is a pseudo-standard supported by fastecho and other "old-school" tossers) - per mark lewis' request.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.83 3.84
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17065

Modified Files:
sbbsecho.c
Log Message:
Address RMH's issue:
When the local system has multiple AKAs for the same zone and we are picking a origin/source address suitable for the destination address, pick the AKA that matches both the zone and net of the destination address first (if there is such a local AKA). It's the same logic used in sbbs_t::netmail() to display
the originating address, so the AKA picking logic now matches what is shown
to the netmail author and what SBBSecho will actually use.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.84 3.85
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28074

Modified Files:
sbbsecho.c
Log Message:
Another improvement to create_netmail():
If the SMB header contains a source FTN address, use that as the origin address of the netmail and do not look-up a local AKA match for the destination address.
Also, fix what appears to have been a (currently harmless) bug in smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail message headers, where the echostats come from. Could just remove
these 2 lines.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.85 3.86
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18682

Modified Files:
sbbsecho.c
Log Message:
When importing packets, don't export previously-rescanned messages
(messages which contain the RESCANNED control line) to downlinks.

Also renamed pkt_to_pkt() to write_to_pkts().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.87 3.88
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12172

Modified Files:
sbbsecho.c
Log Message:
When adding a new sub-board to the area file, if the sub has a "newsgroup"
name specified, use that instead of the short name as the "Echo Tag"
(Area Tag) value.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.88 3.89
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14995

Modified Files:
sbbsecho.c
Log Message:
Fix crash (segfault) reported in AreaFix handler for "-ALL", reported
by Ragnarok@DOCKSUD.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.89 3.90
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log an error if one or more file attachments could not be deleted when attempted.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.90 3.91
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13077

Modified Files:
sbbsecho.c
Log Message:
Don't delete netmail file attachments: just because the netmail was exported
to .msg file doesn't mean you should delete the file attachment! The .msg
file will still be pointing to that file and it needs to be there.
SBBSecho was silently failing to delete file attachments on my system, so
I didn't see this problem. Oops. Anyway, this explains Al's problem with netmail attachments.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.92 3.93
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18679

Modified Files:
sbbsecho.c
Log Message:
Updated failure/error log messages for SMB library function call failures: always include the text description of the last error and the line number.
The logging of the smb.file string is probably redundant since that path
will likely be included in the last_error string.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.94 3.95
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25420

Modified Files:
sbbsecho.c
Log Message:
Fix bug with AreaFix "ECHOSTATS" command: if the echotag specified was not found, it would be added to the list of echoes tracked in echostats.ini. Ideally, a negative-response message would be sent to requester in this case, but we're not doing that currently.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.96 3.97
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1311

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so that when a link is set to passive, areafix notices are NOT sent to them even if "send notices" is specifically set to yes?


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so

that

when a link is set to passive, areafix notices are NOT sent to them even

if

"send notices" is specifically set to yes?

thank you... i'm guessing that the option in the config file toggles when links
change their statuses? glad to see the change wasn't very involved :)

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... I generally prefer normal late-19th century cuisine. ML
---
* Origin: (1:3634/12.73)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to Digital Man on Mon Oct 29 2018 12:56 pm

On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so

that

when a link is set to passive, areafix notices are NOT sent to them even

if

"send notices" is specifically set to yes?

thank you... i'm guessing that the option in the config file toggles when links
change their statuses? glad to see the change wasn't very involved :)

Right. That link setting is modifiable via areafix.

digital man

Synchronet/BBS Terminology Definition #19:
DOCSIS = Data Over Cable Service Interface Specification
Norco, CA WX: 76.9øF, 43.0% humidity, 0 mph E wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.98 3.99
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30801

Modified Files:
sbbsecho.c
Log Message:
Fuzzy Zone operation: make the implementation match the feature description/documentation more closely. That is, if there is an INTL kludge line in the incoming netmail message, there will be no "fuzzy" zone matching. This means that Fuzzy Zone operation will only apply to netmail messages that do *not* have an INTL kludge line (which specifies the source and destination zones already). This solves the problem reported by Mark Lewis with
unexpected Fuzzy Zone behavior (when enabled), it was over-riding the
source zone number even though it was specified (via INTL kludge) in the original netmail message body.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.99 3.100
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17849

Modified Files:
sbbsecho.c
Log Message:
Log a notice-level message when adding a new area to the unknown/bad area list.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.100 3.101
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18772

Modified Files:
sbbsecho.c
Log Message:
Change requested by Mark Lewis: accept area manager (areafix) netmail
requests sent to "SBBSecho" again. SBBSecho used to allow this back in
v3.02 (Nov-2017) and earlier versions, but was removed for loop-safety
since AreaMgr notifications and responses are sent from "SBBSecho", but
we have bot-loop protection built in, so that should be okay.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.102 3.103
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8260

Modified Files:
sbbsecho.c
Log Message:
Longer, hopefully more helpful, "Authenticated EchoMail" warning log msg.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.111 3.112
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31205

Modified Files:
sbbsecho.c
Log Message:
Use FIDO_SOFT_CR (0x8d) rather than the magic number


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.114 3.115
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26186

Modified Files:
sbbsecho.c
Log Message:
Don't warn about free disk space for directories that don't exist.
Log free disk space errors to sbbsecho.log (as well as print to stdout).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.115 3.116
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11356

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

When processing area manager netmail messages, SBBSecho can modify
(add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the node for the sectoin naming.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 2019 Jun 22 15:27:42, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

When processing area manager netmail messages, SBBSecho can modify (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

i've seen this! never was able to spend time to try to figure out the problem so was unable to report the bug... glad to know that it has been found and fixed! yay!

Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the
node for the sectoin naming.

that's like what tickit is doing when it hunts for a system's tic password... look for this and if not found, then look for the other form of address...

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... Don't corner something meaner than you.
---
* Origin: (1:3634/12.73)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.116 3.117
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Don't need lzh.h here.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.120 3.121
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21629

Modified Files:
sbbsecho.c
Log Message:
When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is
*not* the start of a valid control paragraph (kludge line), then
convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we
don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes
causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

)\/(ark

Once men turned their thinking over to machines in the hope that this would set
them free. But that only permitted other men with machines to enslave them.
... A bachelor lives like a king and dies like a beggar.
---
* Origin: (1:3634/12.73)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is
*not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

digital man

Synchronet/BBS Terminology Definition #27:
FOSSIL = Fido/Opus/SEAdog Standard Interface Layer
Norco, CA WX: 90.5øF, 37.0% humidity, 4 mph N wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: Digital Man to mark lewis on Fri Jul 26 2019 11:47 am

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

Before today... :-)

digital man

Synchronet/BBS Terminology Definition #40:
IMAP = Internet Message Access Protocol
Norco, CA WX: 94.5øF, 34.0% humidity, 4 mph NNE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.122 3.123
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8880

Modified Files:
sbbsecho.c
Log Message:
Remove unused variable.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.123 3.124
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10902

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the
delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me. The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in SBBSecho, so
I'll just punt for now and do what Mark asked for. <shrug>



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But
parsing/using the "Flags" control line flags isn't already in
SBBSecho,

exactly...

so I'll just punt for now and do what Mark asked for. <shrug>

the main thing is the files are no longer killed... attached files really should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

)\/(ark

Once men turned their thinking over to machines in the hope that this would set
them free. But that only permitted other men with machines to enslave them.
... But if the handwriting on the wall is a forgery?
---
* Origin: (1:3634/12.73)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Wed Jul 31 2019 08:30 pm

On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in
SBBSecho,

exactly...

so I'll just punt for now and do what Mark asked for. <shrug>

the main thing is the files are no longer killed...

They will be if the KILLSENT flag is sent (which is normal).

attached files really
should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

Okay. I'll probably just add the KFS flag checking and remove the checking of the KILLSENT attr bit for that logic.

digital man

Synchronet/BBS Terminology Definition #9:
BSO = Binkley Style Outbound
Norco, CA WX: 66.2øF, 87.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.124 3.125
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19947

Modified Files:
sbbsecho.c
Log Message:
If SBBSecho imports a message with a "CHRS" control line with a value of "UTF-8", set the msg's auxattr MSG_HFIELDS_UTF8 flag because FTS-5003 states:
"The character set identifier applies to all parts of the message,
including the header information and the control lines like origin
and tear line."



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.125 3.126
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29414

Modified Files:
sbbsecho.c
Log Message:
Use the \1FLAGS KFS (parsed crudely from netmail .msg body text) to trigger file-attachment deletion in write_flofile() - not the KILLSENT attribute flag. Export the SMB MSG_KILLSENT auxattr from SMB mail to FTN netmail \1FLAGS KFS.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.126 3.127
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22270

Modified Files:
sbbsecho.c
Log Message:
Export a default CHRS: (charset) value of "UTF-8" when any of the header fields contain UTF-8 characters.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.127 3.128
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2831

Modified Files:
sbbsecho.c
Log Message:
Same as previous commit, but for EchoMail this time (!).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.128 3.129
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30083

Modified Files:
sbbsecho.c
Log Message:
Revamp the 0-byte inbound bundle handling:
- Don't ever try to unpack a 0-byte file.
- Don't log anything or try delete if the file is < 24 hours old.
- Try to delete the file if it's >= 24 hours old (and log a msg, INFO-level).




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.129 3.130
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4469

Modified Files:
sbbsecho.c
Log Message:
If failure to find a .msg netmail file attachment, don't bail (immediately exit), just log the error and continue processing. Reported by wkitty42.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.130 3.131
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Add missing %s printf args.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.131 3.132
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17560

Modified Files:
sbbsecho.c
Log Message:
Log the process-ID (PID) on the debug-level log lines: "invoked" and "exiting" Always log the "exiting" line when exiting with a non-zero error level.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.132 3.133
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10170

Modified Files:
sbbsecho.c
Log Message:
When importing FTN TZUTC values, don't get fancy trying to convert to a US standard time-zone (e.g. -0300 == EST) as this is not accurate when daylight saving time is in effect (-0400 == EDT or AST?).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.133 3.134
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10866

Modified Files:
sbbsecho.c
Log Message:
Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have
a FLAGS kludge line.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

Ahh, you might have found it?

I'll rebuild and try with the same message anyway...
...ëîå*

... Nursing Law: All the IV trees are at the other end of the hall.

---
þ Synchronet þ Alterant | an SBBS in Docker on Pi!

Re: src/sbbs3/sbbsecho.c
By: Alterego to Digital Man on Mon Aug 19 2019 08:21 am

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

Ahh, you might have found it?

I think so.

I'll rebuild and try with the same message anyway...

Thanks!

digital man

Synchronet "Real Fact" #37:
Synchronet's Windows Control Panel is built with Borland C++ Builder.
Norco, CA WX: 84.4øF, 46.0% humidity, 15 mph NE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.134 3.135
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28445

Modified Files:
sbbsecho.c
Log Message:
Using the new lookup_user() function for destinatino user name look-ups.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.136 3.137
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Beautify the "Adding sub-board" log message a bit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.137 3.138
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log a notice-level msg if the configured areafile can't be opened.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.138 3.139
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6532

Modified Files:
sbbsecho.c
Log Message:
Don't require that the last character of the "DateTime" field of packed messages is a null (0x00) byte. Some broken FidoNet software may include
a full 20 usable characters in their DateTime header field, like so:
"04 Feb 119 20:26:32" - representing February 4th, 2019. Y2K. <sigh>

The DateTime won't be parsed fully correct, but at least the packet won't be rejected outright because it is "Grunged". - for Alterego (ALTERANT)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.139 3.140
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23255

Modified Files:
sbbsecho.c
Log Message:
Revert last commit. The example packed message with the corrupted DateTime
was not a recoverable message header (e.g. the toUserName field was *not*
at offset 0x22):

xx 02 00 01 00 01 00 6A - 02 FE 01 00 00 00 00 30 : .......j.......0
34 20 46 65 62 20 31 31 - 39 20 20 32 30 3A 32 36 : 4 Feb 119 20:26
3A 33 32 04 00 4B 75 72 - 74 20 57 65 69 73 6B 65 : :32..Kurt Weiske

So restore the DateTime field validation: the 20th byte must be null.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.142 3.143
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27640

Modified Files:
sbbsecho.c
Log Message:
When exporting NetMail from data/mail.* to netmail/*.msg, map the SMB
aux/net attributes to FidoNet msg header attributes:
- CRASH
- FILEREQUEST (FREQ)
- RECEIPTREQ (RRREQ)

This should fix the FREQ netmail issue reported by Richard Williamson (RICHARDF). Thanks for the bug report!



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.143 3.144
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15382

Modified Files:
sbbsecho.c
Log Message:
Attempt to re-create outbound directories in mutex (.bsy) file lock loop, just in case something (e.g. Argus mailer) deleted it while we were waiting our
turn to use it. As reported by Alterego (ALTERANT)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.144 3.145
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv398

Modified Files:
sbbsecho.c
Log Message:
More loop prevention: check a message's PATH in addition-to its SEEN-BYs in write_to_pkts():
If for some weird reason a downlink's address is in the PATH, but not in the SEEN-BYs, detect as a loop and don't send to (add to an outbound pkt for) the downlink.

This is an experimental change to see if it addresses the issue reported by Richard Williamson and Mark Lewis with regards to dupes in the COOKING
echo from point nodes off 1:396/45.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.145 3.146
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3751

Modified Files:
sbbsecho.c
Log Message:
Even more loop-prevention paranoia:
If a packed messages contains no PATH or SEEN-BY lines, we can still detect
and prevent a message loop by comparing the origin address in the packet header against the downlink's address and if it's a match, skip that downlink.
It is still possible that a packed message header contains a different origin address than the packet header, and we're actually over-writing the packed messge header variable with the parsed Origin: line address (if there is one), so perhaps we'll want to compare the (actual) packed message header origin address too at some point in the future, if loops continue to be a problem.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.146 3.147
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19001

Modified Files:
sbbsecho.c
Log Message:
Enhancement for Alterego (ALTERANT):
Don't ever route netmail when the destination zone/net/node matches a local
AKA (ignoring the point value).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Nov 17 2019 04:31 pm

Don't ever route netmail when the destination zone/net/node matches a local AKA (ignoring the point value).

Actually, what will happen to it?

I'm assuming if the point is defined in sbbsecho.ini, it will be packed for the downstream point.

But what will happen otherwise? Perhaps it could be re-addressed to the sysop of the AKA, so that they are aware?
...ëîå*

... When two Englishmen meet their first talk is of the weather.

---
þ Synchronet þ Alterant | an SBBS in Docker on Pi!

Re: src/sbbs3/sbbsecho.c
By: Alterego to Digital Man on Mon Nov 18 2019 12:27 pm

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Nov 17 2019 04:31 pm

Don't ever route netmail when the destination zone/net/node matches a local AKA (ignoring the point value).

Actually, what will happen to it?

Normal processing, just not routed.

I'm assuming if the point is defined in sbbsecho.ini, it will be packed for the downstream point.

Yup.

But what will happen otherwise? Perhaps it could be re-addressed to the sysop of the AKA, so that they are aware?

I don't follow.

digital man

This Is Spinal Tap quote #44:
It really, it does disturb me, but i'll rise above it; I'm a professional. Norco, CA WX: 75.1øF, 18.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Alterego on Sun Nov 17 2019 07:02 pm

But what will happen otherwise? Perhaps it could be re-addressed to
the sysop of the AKA, so that they are aware?

I don't follow.

What will happen to the incoming netmail where the point doesnt exist.

IE: Somebody sends a netmail to 1:2/3.4 - and .4 is not configured in sbbsecho.ini, will:
* The netmail still packed up into the outbound for when a .4 does eventually connect, or
* The netmail will be discard
* The packet will be renamed ".bad"...

?

I'm wanting to know what will happen to the netmail and how will the sysop of 1:2/3 know about an incoming netmail destined for a point that has not been configured.
...ëîå*

... I think sex is better than logic, but I can't prove it.

---
þ Synchronet þ Alterant | an SBBS in Docker on Pi!

Re: src/sbbs3/sbbsecho.c
By: Alterego to Digital Man on Mon Nov 18 2019 02:17 pm

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Alterego on Sun Nov 17 2019 07:02 pm

But what will happen otherwise? Perhaps it could be re-addressed to
the sysop of the AKA, so that they are aware?

I don't follow.

What will happen to the incoming netmail where the point doesnt exist.

IE: Somebody sends a netmail to 1:2/3.4 - and .4 is not configured in sbbsecho.ini, will:
* The netmail still packed up into the outbound for when a .4 does eventually connect, or
* The netmail will be discard
* The packet will be renamed ".bad"...

?

I'm wanting to know what will happen to the netmail and how will the sysop of 1:2/3 know about an incoming netmail destined for a point that has not been configured.

The change I made was in pack_netmail(), so the netmail message would still be packed for the destination node, just as if there was no "route" entry matching its address. If the ".4" node ever does connect, it should get the packet with the netmail inside.

digital man

Synchronet "Real Fact" #83:
Donations to the Synchronet project are welcome @ http://wiki.synchro.net/donate
Norco, CA WX: 70.3øF, 21.0% humidity, 0 mph SW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.147 3.148
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Update to previous commit: always read/use the destination node config,
(e.g. for Hold status) even if/when it's a point off of us.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.149 3.150
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log any error reading message header when exporting NetMail (from SMB to *.msg).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.150 3.151
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Fix bug introduced in rev 1.236 (April-3-2014):
Areafix requests to unlink a node from an area would corrupt the list of
linked nodes: the *last* listed node would always be removed. If this was
not the node that submitted the areafix request, then 2 nodes would be
removed from the list of linked-nodes for an echo.
To simplify this, we're just going to not write the removed node back to
the area file, but leave it in the in-memory list. So technically, the node won't be unlinked until the next run of SBBSecho when the area file is re-parsed. If that's a problem, we can always add run-time removal from
the in-memory list later. Reported by Alterego (ALTERANT).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.173 3.174
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22900

Modified Files:
sbbsecho.c
Log Message:
If an export netmail message has MSGID/REPLY header fields, add those as kludges (needed for including message-IDs in exported netmail).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.174 3.175
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1776

Modified Files:
sbbsecho.c
Log Message:
Extra log level message (INFO, WARNING, and DEBUG) when moving netamil file attachments (attached files) - for debugging the issue reported by
alterego (ALTERANT)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.175 3.176
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10832

Modified Files:
sbbsecho.c
Log Message:
import_netmail(): Safer string handline and a bit more/consistent log output around attached file handling (especially if mv() fails).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/57afc83c4a58a1a7f6af05ee
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Signal the sub-board's configured semaphore file when importing echomail

At the request of alterego (ALTERANT), if a sub-board has a "post semaphore" configured, signal (touch) it whenever a message is imported via SBBSecho into that sub-board.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ddba8d7cec9cd0367d7e0480
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix previous commit: we need to use mycmdstr(), not cmdstr().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/da486a78c63293a86718c78d
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Don't attempt to parse origin addr from origin lines in NetMail msgs

Apparently, some versions or configurations of Mystic BBS will include an Origin Line in FTN NetMail messages. That would've been okay for SBBSecho, except these origin lines do not contain an FTN address (in parenthesis).

So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don't attempt to parse any Origin Lines. Secondly, fix up the Origin Line parse
code a bit better detect the case when no FTN address is actually present.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/6380257eb617c61048195583
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Support forwarding FTN netmail to user's forward-to netmail address

There's no new opt-in option for this new feature - maybe there should be.
For geneb.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/796c3db7d2e5fdb81b1c4dff
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
A better check of a user's netmail-forwarding address.

is_supported_netmail_addr() actually takes the system configuration and QWK routing table into account. No sense forwarding to a non-deliverable address.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/efbb1b5d5577a05515f1f6e5
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Revert "A better check of a user's netmail-forwarding address."

This reverts commit 796c3db7d2e5fdb81b1c4dff884e15d66718063c.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbda86ec8738498c14ae87fb
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix netmail forwarding (new feature)

The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.

Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").

For geneb.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a1e127841841087fb51e1c32
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Don't repeate mail "comment" headers in exported netmail msgs

smb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.
When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).

Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c590c437c7dee6de8531217b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Use QWKnet ID of originating system when imported via QWKnet

Update to previous commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1031d0f6e01686c5a8dda583
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Replace tempnam() usage with the suggested mkstemp()

Since we're cleaning up warnings... this will break the Windows build for now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0f262d8ab2a6bd870adbb428
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-board

It was recently pointed out to me that a downlink could link to the '*' echo via Area Manager (AreaFix) request. This was not intentional.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7f0390149d84d79a3b7bfb10
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Keep the same area file (areas.bbs) mode flags (permissions)

When executing area manager requests that alter the area file, the temp area file created (with mkstemp) had mode 0600 (owner read/write only). The sysop very possibly had different permission flags they want to keep for their area file, so copy the mode flags from the original area file to the temp/new area file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9a8c8e6d414c2bfe503aa841
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Microsoft doesn't have fchmod(), so use chmod() on the closed file

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net