src/sbbs3 xtrn.cpp 1.229 1.230
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Resolve a couple GCC warnings:
unused variable 'p'
comparison between signed and unsigned integer expressions



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.230 1.231
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Fri Apr 06 2018 00:08:37

xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).

I'm soryy, may I ask what the issues was? I use this option along with most of the time RELEASE=1 (my latest build was yesterday) The only issues I had with dosemu was changing the DOSEMU path in sbbs.ini. For some reason /usr/bin/dosemu.bin worked fine forever and about a month or so it just stopped working (im sure you remember my emails), So I said screw might as well just try "dosemu" as the value since I could pull dosemu from my cli with no issues, and it started working.

Would this have anything to do with that issue?

--

Tim Smith (KK4QBN)
KK4QBN BBS

---
* Synchronet * KK4QBN BBS - kk4qbn.com - 706.422.9538 - EM74OR - NW GA USA

Re: src/sbbs3/xtrn.cpp
By: KK4QBN to rswindell on Fri Apr 06 2018 08:38 am

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Fri Apr 06 2018 00:08:37

xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).

I'm soryy, may I ask what the issues was? I use this option along with most of the time RELEASE=1 (my latest build was yesterday) The only issues I had with dosemu was changing the DOSEMU path in sbbs.ini. For some reason /usr/bin/dosemu.bin worked fine forever and about a month or so it just stopped working (im sure you remember my emails), So I said screw might as well just try "dosemu" as the value since I could pull dosemu from my cli with no issues, and it started working.

Would this have anything to do with that issue?

No. There was a harmless warning when building withOUT USE_DOSEMU (unused variable defined) - I moved the variable definition into the block where it's used (the USE_DOSEMU stuff), but did it incorrectly which caused the build of xtrn.cpp to fail, temporarily.

digital man

Synchronet/BBS Terminology Definition #18:
DSZ = DOS Send ZMODEM (by Chuck Forsberg)
Norco, CA WX: 57.9øF, 81.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.231 1.232
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17343

Modified Files:
xtrn.cpp
Log Message:
Removed an apparent debug-output (to stderr) line (output the path to emusetup.bat).
It was generating an (easy to fix) GCC 5.4.0 warning:
format not a string literal and no format arguments [-Wformat-security]
But the line was not needed, so just removed it.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: Digital Man to KK4QBN on Fri Apr 06 2018 23:48:56

No. There was a harmless warning when building withOUT USE_DOSEMU (unused variable defined) - I moved the variable definition into the block where it's used (the USE_DOSEMU stuff), but did it incorrectly which caused the build of xtrn.cpp to fail, temporarily.

Ahh ok, I'm still vexed as to why my dosemu games will not work when I put the full path and filename to dosemu.bin in sbbs.ini instead of just 'dosemu' it works so thats fine.. but its just strange that using it the 'correct' way worked for close to 2 years, then suddenly I started getting close to 50 errors daily and find that my DOS doors are not working, a lot of the errors were even errors becaus teh DOS events I had setup for processing league packets were erroring out and then backing up the other events so they would'nt run, one big huge domino effect.

I still to the day do'nt know why I have to run dosemu like that, but since I changed it, all errors have gone away and everything is running smooth.

--

Tim Smith (KK4QBN)
KK4QBN BBS

---
* Synchronet * KK4QBN BBS - kk4qbn.com - 706.422.9538 - EM74OR - NW GA USA

src/sbbs3 xtrn.cpp 1.232 1.233
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32518

Modified Files:
xtrn.cpp
Log Message:
Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in *nix-builds (for stdio WWIV doors).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.233 1.234
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13808

Modified Files:
xtrn.cpp
Log Message:
Fix FreeBSD build, broken by revision 1.230




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.234 1.235
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32165

Modified Files:
xtrn.cpp
Log Message:
Add clarification to the "No startup directory" error, that this is only
for DOS programs (part of the USE_DOSEMU patch).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Thu Jun 21 2018 13:23:44

Great addition ;)

Marisa
--- https://AmigaCity.xyz - Portal for the Amiga - More than 2,600 free DLs
--- https://AmigaCityLaptops.com - Laptops & Handhelds that run AmigaOS
--- https://AmigaCity.xyz/radio.html - Amiga game music 24/7
--- https://BBSlist.SynchronetBBS.org - Active BBS List for all BBS types
--- https://SynchronetBBS.org/OurServers - A list of all our websites
--- https://gamenet.SynchronetBBS.org - GameNet BBS Network
þ Synchronet þ Amiga City - The BBS for the Amiga - more than 2,500+ files

Re: src/sbbs3/xtrn.cpp
By: Marisag to rswindell on Sat Jun 23 2018 02:54 am

Great addition ;)

Please quote the part of the message you're repying to. What exactly is a great addition?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/xtrn.cpp
By: Nightfox to Marisag on Sun Jun 24 2018 22:20:08

Please quote the part of the message you're repying to. What exactly is a great addition?

Sorry, I was commenting on that change that was made due to my request ;)

Marisa
--- https://AmigaCity.xyz - Portal for the Amiga - More than 2,600 free DLs
--- https://AmigaCityLaptops.com - Laptops & Handhelds that run AmigaOS
--- https://AmigaCity.xyz/radio.html - Amiga game music 24/7
--- https://BBSlist.SynchronetBBS.org - Active BBS List for all BBS types
--- https://SynchronetBBS.org/OurServers - A list of all our websites
--- https://gamenet.SynchronetBBS.org - GameNet BBS Network
þ Synchronet þ Amiga City - The BBS for the Amiga - more than 2,500+ files

src/sbbs3 xtrn.cpp 1.236 1.237
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6996

Modified Files:
xtrn.cpp
Log Message:
Another eprintf to lprintf change.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.239 1.240
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Improved error log messages:
- include errno description (strerror output)
- exclude (redundant) node number



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.247 1.248
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27921

Modified Files:
xtrn.cpp
Log Message:
Log a warning or error if an external program is attempted to be executed but can't because it's a DOS program and the current node doesn't support it.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.248 1.249
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24309

Modified Files:
xtrn.cpp
Log Message:
Pipe non-binary external program output through rputs() so we get charset translation "for free". Windows only for now.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.251 1.252
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19890

Modified Files:
xtrn.cpp
Log Message:
When the passthru_thead is running, the protocol (%p) command-line specifier will now expand to "raw" rather than "telnet/rlogin/ssh". This disables IAC handling in sexpots, for example, which isn't needed or desired when using
the passthru socket.

Also, put some conditional checks for passthru_thread_running in external()
and if it's not (e.g. for testing purposes), then lock the input_thread_mutex instead of changing passthru_socket_active. This is currently just a way to easily test the differences between direct and passthru socket I/O
(dependant on whether or not the passthru_thread is running which is controlled in main.cpp.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Wed Aug 21 2019 11:31 am

When the passthru_thead is running, the protocol (%p) command-line specifier will now expand to "raw" rather than "telnet/rlogin/ssh". This disables IAC handling in sexpots, for example, which isn't needed or desired when using the passthru socket.

Course I meant to say "sexyz", not "sexpots". I seem to be conflating those two stupid program names more often latey.

digital man

Synchronet/BBS Terminology Definition #36:
HTTPS = Secure HTTP (authenticated and encrypted HTTP over TLS)
Norco, CA WX: 87.9øF, 31.0% humidity, 6 mph E wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.252 1.253
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3213

Modified Files:
xtrn.cpp
Log Message:
Use the telnet_expand() from telnet.c now.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.256 1.257
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28552

Modified Files:
xtrn.cpp
Log Message:
In *nix builds, change the second almost identical log "Executing external"
log message to:
- only log the message if the "full command line" is different than the
command-line argument to the external() function. I'm pretty sure that was
the reason for the addition of this log message, for debugging Linux-DOSEMU
issues where the fullcmdline != cmdline.
- change from INFO to DEBUG log level
- change the message from "executing external: " to "Executing cmd-line: "



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.262 1.263
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16614

Modified Files:
xtrn.cpp
Log Message:
Add support for %^ command-line specifer which expands to the system architecture (e.g. "i686" for Win32 builds, "x64" for Linux-x86_64 builds).
Currently, there underlying XPDEV macro definition does not differentiate between arm32 and arm64, but it should. Next...


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec5cbb848bc16419cc4267a9
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix compile issue in previous commit. Add more semicolons.

One can't have too many semicolons.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ccf41a4c15bfdbb1b1aa46d3
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't log blank lines output from external programs on *nix

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e2a9066d89af60010e8bf55b
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix Linux-DOSEMU buffer overflow warnings with sprintf() usage (!!!)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8312547f3d4e276ac722b7df
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Trim left-most whitespace from stderr lines of externals before logging.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ca424956d4f80d5d313b7eca
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't do the special DOSEMU cmdline specifier magic if the cmd starts with '?'

JavaScript modules are intuitively "native" and have not historically required the "native" option to be set to "yes" in SCFG.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/02a967b2403024c0a572eb45
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Trim white-space from the start of stderr-logged string from xtrns

... like the last commit that did this, but do in the other 2 places where stderr output is logged as log messages.
Also, include the extended program name in the stderr log messages, making it easier to find the output you're looking for.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5a1ab6a7e8040e06aecf3868
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
A second pass at: Better native vs. DOS cmd-line detection in cmdstr()

cmdstr() is often called for non-executable command-lines (e.g. for @include: file name/path arguments), so don't default to native unless a mode value was specified. Hopefully addresses issue reported by bobrob without breaking anything else (again).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/87926cdac705ac979c403a5d
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix new GCC warning about unused variable.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net