rswindell wrote to CVS commit on 05-09-18 11:48 <=-
exec newslink.js 1.108 1.109
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv23562
Modified Files:
newslink.js
Log Message:
Created a new function (save_ptr) to elminate some redundant code.
Removed support for the long-deprecated .snl import/export pointer
files (uses the long-supported .ini file now only, [NewsLink] section). Added more debug output (enabled with the -d switch) when skipping
(not exporting) any locally posted messages to help debug Bill
McGarrity's reported problem.
5/9 07:36:20p cmd: Message-ID: undefined
5/9 07:36:20p !POST FAILURE: 441 posting failed
Re: exec/newslink.js
By: Bill McGarrity to rswindell on Wed May 09 2018 07:56 pm
5/9 07:36:20p cmd: Message-ID: undefined
I think that ^^^
5/9 07:36:20p !POST FAILURE: 441 posting failed
Is causing this ^^^
So... there's no message-ID stored with the message and one isn't being dynamically generated when newslink reads the msg-header. I'll look into it.
Digital Man wrote to Bill McGarrity on 05-09-18 18:55 <=-
Re: exec/newslink.js
By: Bill McGarrity to rswindell on Wed May 09 2018 07:56 pm
5/9 07:36:20p cmd: Message-ID: undefined
I think that ^^^
5/9 07:36:20p !POST FAILURE: 441 posting failed
Is causing this ^^^
So... there's no message-ID stored with the message and one isn't being dynamically generated when newslink reads the msg-header. I'll look
into it.
Digital Man wrote to Bill McGarrity on 05-09-18 20:37 <=-
Re: exec/newslink.js
By: Digital Man to Bill McGarrity on Wed May 09 2018 06:55 pm
Re: exec/newslink.js
By: Bill McGarrity to rswindell on Wed May 09 2018 07:56 pm
5/9 07:36:20p cmd: Message-ID: undefined
I think that ^^^
5/9 07:36:20p !POST FAILURE: 441 posting failed
Is causing this ^^^
So... there's no message-ID stored with the message and one isn't being dynamically generated when newslink reads the msg-header. I'll look into it.
I can't seem to reproduce what you're seeing. It's somewhat normal to
have a message with no message-ID and when the header of such a message
is read via JavaScript (e.g. newslink.js), the message-ID is
dynamically generated. I tested this using a little test script and it worked fine. What version of Synchronet are you using? Are you running newslink via jsexec or as an event in Synchronet?
I can't seem to reproduce what you're seeing. It's somewhat normal to have a message with no message-ID and when the header of such a message is read via JavaScript (e.g. newslink.js), the message-ID is dynamically generated. I tested this using a little test script and it worked fine. What version of Synchronet are you using? Are you running newslink via jsexec or as an event in Synchronet?
Here are the versions of Synchronet:
Synchronet Terminal Server 3.17a SMBLIB 2.60 Compiled Apr 30 2018 05:02:26
I just committed to CVS a test script, msgutil.js. Can you run that
on the message base in question and post the header output for the
problem message (the one with the "undefined" message-ID)?
When I use this script to show the headers of a message base which contains a message with no message-ID, the "id" property value is dynamically generated (a valid RFC-822 compliant message ID is
created). NewsLink (newslink.js) uses the exact same method for
retrieving the message header and should be getting the same result.
You can run msgutil.js using jsexec like so: "jsexec msgutil <internal-code>" where <internal-code> is the internal code of the
msgbase in question. Right now, this script just dumps all the index
and header files for all the messages in the base.
OK... done. Here is the output on the message uploaded in the REP pkt:
13067
id = <5AF385D3.13067.usenet_altbbsfg@tequilamockingbirdon
line.net>
Here is the msg that I wrote while online:
13068
id = <5AF38902.13068.usenet_altbbsfg@tequilamockingbirdon
line.net>
Now as I orginally stated, I gate this to both FTN and UUCP. FIDOOUT ran on both occasions (when u/l in REP pkt and when saved online.) As you can
see, the first doesn't have any FTM properties as well.
Digital Man wrote to Bill McGarrity on 05-10-18 14:34 <=-
Re: exec/newslink.js
By: Bill McGarrity to Digital Man on Thu May 10 2018 04:49 pm
OK... done. Here is the output on the message uploaded in the REP pkt:
13067
id = <5AF385D3.13067.usenet_altbbsfg@tequilamockingbirdon
line.net>
Here is the msg that I wrote while online:
13068
id = <5AF38902.13068.usenet_altbbsfg@tequilamockingbirdon
line.net>
Okay, cool, in both cases, the JS msg header includes the "id" field
which is what is used to populate the NNTP article "Message-ID" header field.
Now as I orginally stated, I gate this to both FTN and UUCP. FIDOOUT ran on both occasions (when u/l in REP pkt and when saved online.) As you can
see, the first doesn't have any FTM properties as well.
That shouldn't matter: The FTN header fields/properties aren't required for NNTP article headers.
So the next question... if you run newslink.js using jsexec, do you
have the same problem (the "undefined" Message-ID)?
found in message #64sub: usenet_altbbsfg, newsgroup: alt.sports.baseball.sf-giants usenet_altbbsfg.ini export ptr: 13083
OK... I uploaded a REP pkt and ran jsexec newslink.js -d
Here is the output for that sub...
sub: usenet_altbbsfg, newsgroup: alt.sports.baseball.sf-giants usenet_altbbsfg.ini export ptr: 13083
usenet_altbbsfg.ini import ptr: 331895
exporting local messages
cmd: POST
rsp: 340 send article
cmd: From: "Bill McGarrity" bill.mcgarrity@tequilamockingbirdonline.net.remove-
p1y-this>
cmd: To: All
cmd: Subject: One more test...
cmd: Message-ID: undefined
cmd: Date: Thu, 10 May 2018 20:59:00 -0400
cmd: X-Comment-To: All
cmd: Organization: TequilaMockingbird Online
cmd: Newsgroups: alt.sports.baseball.sf-giants
cmd: Content-Type: text/plain; charset=IBM437
cmd: Content-Transfer-Encoding: 8bit
cmd: X-Gateway: tequilamockingbirdonline.net [Synchronet 3.17a-Win32 NewsLink
.
109]
cmd:
cmd: .
rsp: 441 posting failed
!POST FAILURE: 441 posting failed
cmd: GROUP alt.sports.baseball.sf-giants
rsp: 211 76 331820 331895 alt.sports.baseball.sf-giants alt.sports.baseball.sf-giants import ptr: 331895, first_msg: 331820, last_msg:
31895
Synchronet NewsLink 1.109 session complete (0 exported, 0 imported) c:\sbbs\exec\newslink.js executed in 60.35 seconds
As you can see it wasn't exported.
Here is the output on the above msg from msgutil.js:
13084
id = 5AF4EB15.13084.usenet_altbbsfg@tequilamockingbirdon
line.net>
Digital Man wrote to Bill McGarrity on 05-14-18 16:45 <=-
I currently have no theories why newslink.js would retrieve a missing/undefined 'id' property in the message header object yet msgutil.js gets the (dynamically-generated) header 'id' field/property just fine.
I expect when you run the updated newslink.js, you should see a printed/logged message like "Message #13085 is missing a Message-ID
header field", based on the reported error. Now, *why* the property is missing is still a mystery to me. Please let me know.
Bill McGarrity wrote to Digital Man on 05-15-18 02:24 <=-
That's exactly the message I received....
5/15 01:54:10a sub: usenet_altbbsfg, newsgroup: alt.sports.baseball.sf-giants
5/15 01:54:10a usenet_altbbsfg.ini export ptr: 13125
5/15 01:54:10a usenet_altbbsfg.ini import ptr: 331934
5/15 01:54:10a Message #13126 is missing a Message-ID header field
5/15 01:54:10a alt.sports.baseball.sf-giants import ptr: 331934, first_msg: 331859, last_msg: 331934
Again, when I upload a REP pkt and it gets imported into the sub, there's no Message-ID assigned although it shows on when I run the msgutil.js.
Digital Man wrote to Bill McGarrity on 05-15-18 16:39 <=-
Re: exec/newslink.js
By: Bill McGarrity to Digital Man on Tue May 15 2018 02:24 am
Again, when I upload a REP pkt and it gets imported into the sub, there's no Message-ID assigned although it shows on when I run the msgutil.js.
Yeah, that part was expected and not a bug. The other part (where the
"id" property was not being dynamically generated for the message
header) should now be fixed in CVS.
Sysop: | r00t |
---|---|
Location: | Newport Beach, CA |
Users: | 13 |
Nodes: | 6 (0 / 6) |
Uptime: | 33:04:53 |
Calls: | 145 |
Files: | 238 |
Messages: | 33,772 |