• src/sbbs3/js_msgbase.c

    From rswindell@VERT to CVS commit on Tuesday, May 15, 2018 22:41:00
    src/sbbs3 js_msgbase.c 1.219 1.220
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17644

    Modified Files:
    js_msgbase.c
    Log Message:
    Fix get_msg_header() problem reported by Bill McGarrity:
    "expand fields" could be misinterpretted (e.g. as 'false') if less than 3
    args were passed to the function. Apparently you can NOT assume that argv[argc] is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem, MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js) and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true and then argv[n] evalulated as false, which would cause a message with no message ID to not have one dynamically created, which would then cause the message to fail to post to an NNTP server due to malformed Message-ID (a missing message "id" property would end up being included in the newsgropu article header as "Message-ID: undefined").

    get_msg_index() had a similar potential issue, also fixed.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, July 16, 2018 05:42:00
    src/sbbs3 js_msgbase.c 1.220 1.221
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8385

    Modified Files:
    js_msgbase.c
    Log Message:
    Rename this private_t.status to private_t.smb_result, to avoid confusion
    with smb_t.status.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, October 03, 2018 08:13:00
    src/sbbs3 js_msgbase.c 1.222 1.223
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25520

    Modified Files:
    js_msgbase.c
    Log Message:
    Added "tags" to the message header property fields populated when getting
    a message header.
    Added "tags" and "summary" (previously missing) to the property fields
    parsed when adding/writing a message header. This parse code is getting particulary copy/pasta and should be converted to a table-driven loop
    reusing the same logic.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, January 21, 2019 10:10:00
    src/sbbs3 js_msgbase.c 1.223 1.224
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20155

    Modified Files:
    js_msgbase.c
    Log Message:
    Attempt to clarify all this MsgBase.get...(by_offset, number_or_offset_or_id_header)
    confusion: You should not pass both a message number *and* a message header to the
    retrieval methods that support referring to a message by either (number/offset, id
    or header).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, January 22, 2019 03:18:00
    src/sbbs3 js_msgbase.c 1.224 1.225
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16237

    Modified Files:
    js_msgbase.c
    Log Message:
    Beautification/typo of MsgBase methods by_offset blurb.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 29, 2019 04:07:00
    src/sbbs3 js_msgbase.c 1.239 1.240
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv9181

    Modified Files:
    js_msgbase.c
    Log Message:
    Add support for new message header fields:
    - to_list (RFC822TO, previosuly unavailable via JS)
    - cc_list
    - replyto_list (RFC822REPLYTO, previously unavailable via JS)

    Added RFC822FROM to the "field_list" array (previously unavailable via JS). Removed SMB_CARBONCOPY from the "field_list" (now duplicated in cc_list).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 29, 2019 05:46:00
    src/sbbs3 js_msgbase.c 1.240 1.241
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26854

    Modified Files:
    js_msgbase.c
    Log Message:
    Includes SMTP "Received" header fields in field_list array.
    Refer to the dubious get_msg_body() feature of dot-stuffing as that ("dot-stuffing") and not "rfc822-encoding" - because it isn't.
    dot-stuffing is a requirment of SMTP (RFC*821) and NNTP, not RFC822 (oops).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, April 30, 2019 08:26:00
    src/sbbs3 js_msgbase.c 1.241 1.242
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16191

    Modified Files:
    js_msgbase.c
    Log Message:
    Added the (optional) message header object read-only MIME-related properties:
    - mime_version (from the message header, if MIME)
    - content_type (from the messgae header, if MIME)
    - charset (from the plain-text MIME portion content-type header field)



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, May 02, 2019 00:18:00
    src/sbbs3 js_msgbase.c 1.242 1.243
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8956

    Modified Files:
    js_msgbase.c
    Log Message:
    get_all_msg_headers():
    Copy the upvotes, downvotes, and total_votes to the smbmsg_t, replicating
    what is done in sbbs_t::scanposts() - these are used by sbbs_t::show_msghdr() so we need to copy them if we're going to be replicating that functionality (showing up/down votes and score) in message headers shown with bbs.show_msg() and bbs.show_msg_header().


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, May 03, 2019 00:27:00
    src/sbbs3 js_msgbase.c 1.244 1.245
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1076

    Modified Files:
    js_msgbase.c
    Log Message:
    Document the message header fields:
    - votes
    - priority
    - delivery_attempts



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, July 16, 2019 08:04:31
    src/sbbs3 js_msgbase.c 1.248 1.249
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14339

    Modified Files:
    js_msgbase.c
    Log Message:
    Use Spidermonkey's JS_ValueToECMAUint32() rather than our own JS_ValueToUint32() for converting to integers where we may need the full 32 bits.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, July 24, 2019 09:29:03
    src/sbbs3 js_msgbase.c 1.249 1.250
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22884

    Modified Files:
    js_msgbase.c
    Log Message:
    New read-only msg header property populated by get_msg_header() method:
    - Boolean: is_utf8
    In the case of multi-part MIME messages, this may not be populated
    accurately until the message body is read with the get_msg_body() method.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 06, 2019 05:04:30
    src/sbbs3 js_msgbase.c 1.250 1.251
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14631

    Modified Files:
    js_msgbase.c
    Log Message:
    Handle setting msg.hdr.delivery_attempts in parse_header_object()



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, August 23, 2019 04:50:06
    src/sbbs3 js_msgbase.c 1.251 1.252
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23668

    Modified Files:
    js_msgbase.c
    Log Message:
    Add ftn_charset property for message headers. This header field corresponds with the FTN (FTS-5003) "CHRS" control line/paragraph. The values recoginized by Synchronet are:
    "ASCII 1"
    "CP437 2"
    "UTF-8 4"

    These values indicate that header fields and body text of a message are
    encoded with the specifiec charset. The default (assumed charset, if not specified), is CP437.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sunday, November 22, 2020 08:14:40
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/325b9b76b4ace104d93cc220
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    Resolve newish gcc warning about unused set variable.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, May 23, 2021 04:44:37
    https://gitlab.synchro.net/main/sbbs/-/commit/4c2ec210bbee64521dd85b36
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    Fix mime_version and content_type property names in JSDOCS

    Underscores are more JS friendly (and correct).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, July 11, 2021 05:58:26
    https://gitlab.synchro.net/main/sbbs/-/commit/e53c5926508c739c27c4d67c
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    Ignore the PRIVATE message attribute for the "mail" base

    When setting the value of a message's 'can_read' property, ignore the PRIVATE message attribute (which is sometimes set in FTN netmail messages) since it's assumed all messages in the mail base are private, no special destination (to) name matching is needed here.

    This only popped up recently via msglist.js because of the recent addition of checking each messages's 'can_read' property.

    As reported by <Diehard> via IRC PM.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net