• src/sbbs3/js_user.c

    From rswindell@VERT to CVS commit on Thursday, June 07, 2018 02:21:00
    src/sbbs3 js_user.c 1.103 1.104
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    js_user.c
    Log Message:
    Improve JS User class/object reads across a local network by leaving the user.dat file open (for read operations only). Writing still opens and
    closes the user.dat for each property/field modification.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, June 07, 2018 02:35:00
    src/sbbs3 js_user.c 1.104 1.105
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    js_user.c
    Log Message:
    Updated the JSDOC description of a few User properties.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 07, 2018 00:49:00
    src/sbbs3 js_user.c 1.105 1.106
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    js_user.c
    Log Message:
    js_CreateUserObject(): if passed an internal user_t representation, the
    user data is thusly cached - set the 'cached' property member to TRUE. This prevents an unnecessary re-read of the user file and the leaving the user file (user.dat) open, at least for JS contexts that contain a "user" object. I don't think this explains the "too many open files" errors, but it explains at least *some* number of the user.dat open file descriptors.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 07, 2018 02:16:00
    src/sbbs3 js_user.c 1.106 1.107
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    js_user.c
    Log Message:
    If the user number is 0, don't open the user file (user.dat) - the read
    of the user record is going to fail anyway. *this* explains a lot of
    instances of the user.dat file being open concurrently, at least one per
    active thread with a JS context.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, January 10, 2019 19:53:00
    src/sbbs3 js_user.c 1.107 1.108
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17399

    Modified Files:
    js_user.c
    Log Message:
    JSDOCS: Better example for User object creation.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, July 15, 2019 06:53:47
    src/sbbs3 js_user.c 1.110 1.111
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32210

    Modified Files:
    js_user.c
    Log Message:
    Fix issues with the feature added in rev 1.96 by deuce, Jun 17 2012:
    Setting user.security.flags[1-4], exemptions, or restrictions to a string value would result in unexpected modified values:

    1. The exiting flags were all based on the current value of flags1 (copy/paste
    error it appears)
    2. The set/removed/added flags were all "off-by-one" because str_to_bits()
    treats 'A' as bit-1, not bit-0.

    emailval.js is now using this feature and PSI-Jack reported the "interesting" behavior. :-)


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Sunday, August 18, 2019 04:27:48
    src/sbbs3 js_user.c 1.111 1.112
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32518

    Modified Files:
    js_user.c
    Log Message:
    Don't return negative values from user.get_time_left(), instead, clamp to INT32_MAX.




    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Sunday, August 18, 2019 04:42:51
    src/sbbs3 js_user.c 1.112 1.113
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1954

    Modified Files:
    js_user.c
    Log Message:
    Add note to user.get_time_left() documentation that you likely want bbs.get_time_left() instead.




    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, August 21, 2019 01:32:09
    src/sbbs3 js_user.c 1.113 1.114
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11883

    Modified Files:
    js_user.c
    Log Message:
    Address MSVC2019 warning C4244:
    '=': conversion from 'time_t' to 'unsigned long', possible loss of data



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 11, 2020 03:54:58
    src/sbbs3 js_user.c 1.118 1.119
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7146

    Modified Files:
    js_user.c
    Log Message:
    The MOUSE user setting flag is bit 31 (1<<31). Modifying a user.setting property with bit 31 set would result in a user.setting value of 0xffffffff which means the user is both deleted and inactive (all bits are set).
    JS_ValueToInt32() does "bad things" when bit-31 is set in the value being converted, use JS_ValueToECMAInt32 or JS_ValueToECMAUint32 instead.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Saturday, October 03, 2020 19:55:26
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/7faa8a64b0ff3506e3f1fc5f
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Add user properties: birthyear, birthmonth, and birthday

    These allow the easy reading or writing of these sub-field values of the user.birthdate property. When migrating from the legacy formats (e.g. MM/DD/YY or DD/MM/YY), it's required to write all 3 properties to get a correct birthdate/age. Otherwise, "13/31/69" could become "19691/69" (for example) which isn't going to parse correctly.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Saturday, October 03, 2020 23:30:58
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/fe2b242524ada9e70c4d1410
    Modified Files:
    src/sbbs3/js_user.c
    Log Message:
    Allow negative user property values (e.g. age).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net