• src/sbbs3/postmsg.cpp

    From rswindell@VERT to CVS commit on Wednesday, August 29, 2018 04:19:00
    src/sbbs3 postmsg.cpp 1.109 1.110
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26448

    Modified Files:
    postmsg.cpp
    Log Message:
    Include the vote(s) in the message (telegram) sent to the pollster upon a posted vote msg - the format of the vote(s) is currently hard-coded and not colorized/pretty. This'll require an update to the PollVoteNotice text.dat line.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, September 02, 2019 04:54:18
    src/sbbs3 postmsg.cpp 1.127 1.128
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26458

    Modified Files:
    postmsg.cpp
    Log Message:
    Don't create the security-related header fields if the assocated "client" object/struct doesn't have any meaningful data. Prevent this from happening:
    SenderTime 19700101000000Z
    SenderIpAddr
    SenderHostName
    SenderPort 0



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, September 02, 2019 05:42:14
    src/sbbs3 postmsg.cpp 1.128 1.129
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2344

    Modified Files:
    postmsg.cpp
    Log Message:
    Automatic UTF-8 header field detection in savemsg(): if the to, from, or subject header fields are non-ASCII yet valid UTF-8, set the auxattr flag indicating that the msg header is in UTF-8.
    This function is used by JS MsgBase.save_msg(), so any scripts/services that use it (e.g. nntpservice, newslink, imapservice, etc.) to save messages with header fields that may be UTF-8 encoded will automatically benefit from this detection. Mixing CP437 (the default) with UTF-8 encoded header fields is not supported, so if one header field is valid UTF-8 (not plain US-ASCII), then they had better all be either plain US-ASCII or UTF-8 or there will be
    UTF-8 decoding issues when attempting to display or convert later.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, October 01, 2020 04:25:17
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/97bade44ebad5b431485e93c
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Notify local recipients of locally-posted messages addressed to them.

    While SBBSecho would notify local users of imported messages addressed to
    them (both EchoMail and NetMail) and QWK-imported messages recently gained
    the ability to notify local recipients of messages addressed to them, other methods of posting messages (e.g. just using the normal terminal server
    method, e.g. the 'P' command) or using any JavaScript (e.g. web) methods of posting messages lacked recipient notifications. So that's now fixed.
    And for JavaScript-saved local email messages too. I don't *think* this will result in any duplicate notifications of received messages, but let me know
    if you see excess/duplicate notifications.
    Anonymously posted messages are excluded.
    Messages posted to yourself are excluded (who does that?).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, October 01, 2020 04:26:58
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/f4ac7f3920abba7d3c717e3d
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Resolve a gcc warning about signedness.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Saturday, October 03, 2020 19:16:52
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c8193766c6b75abb18a2c257
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Fix savemsg() bug introduced in 97bade44eb (Sep-30), returning false failure

    'i' is the return value of savemg(), used to determine success or failure
    (and what kind of failure) - so we can't use that for the usernumber of
    the recipient.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, November 12, 2020 01:55:49
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/a852cced25cbf1285825942f
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Reduce unnecessary posted-to username searches. Auto-UTF8 in savemsg().

    When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

    savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net