src/sbbs3 exec.cpp 1.105 1.106
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29468

Modified Files:
exec.cpp
Log Message:
Log an error when attempting to execute a 0-byte .bin file.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 exec.cpp 1.108 1.109
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
exec.cpp
Log Message:
if sbbs_t::exec_bin() is called with a blank or NULL module name, just
return an error value (-33, it's the magic number).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 exec.cpp 1.109 1.110
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27351

Modified Files:
exec.cpp
Log Message:
Optimize: don't search for file extension repeatedly.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/256251869f924e3acc9ffb8d
Modified Files:
src/sbbs3/exec.cpp
Log Message:
Previous commit fixed issue with JS_GC before JS_ENDREQUEST

So revert the order back to the way it was in aa2bcd61e9017816d06e581eef478 (don't you love these git references?).

Also, the previous fix for js_execfile() calls for global hot-key events also fixed the EX_JS_CX feature I was working on (js_execmodule)!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/175d0fbc996e5292480bab8e
Modified Files:
src/sbbs3/exec.cpp
Log Message:
Always evaluate js.on_exit() installed expressions.

I noticed that when executing an external JS with the new "Use Shell / New Context" option set to "Yes", that any expressions (strings) installed via js.on_exit() were not being executed upon exit from the script. These on-exit strings are important for restoring global state information (e.g. control key pass-through, console mode) to the original state before the JS mod made any changes.

I'm not sure why the special treatment of "scope == NULL" is through-out this function. Going back to v3.16, it appears this was special treatment for JS mods invoked via global hot key event (when scope != NULL). When invoking an xtrn JS mod with the new Context option, the scope argument is not NULL, so this check was defeating the parsing of the "exit_code" and the evaluation of any js.on_exit() installed expressions for no apparent reason. I can't think why global hot key events should be excluded from this logic either.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b287a8d0887dce091a965ede
Modified Files:
src/sbbs3/exec.cpp
Log Message:
Log a better error when attempting to execute a non-existent module.

Don't complain that exec/<modname>.bin can't be opened. Instead, complain that <modname> doesn't exist and therefore can't be executed. The old message could be misleading/confusing if the expected module is a JS mod (not Baja-compiled .bin mod).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/10d7a690029318dc4ff59ffa
Modified Files:
src/sbbs3/exec.cpp
Log Message:
Merge branch 'master' of gitlab.synchro.net:main/sbbs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/47f8c020a88939d18a033542
Modified Files:
src/sbbs3/exec.cpp
Log Message:
JS module command-lines now supported quoted arguments (w/white-space)

Example:
Command-line: ?showargs " a b c "d "e f"
argc = 3
argv[0] = ' a b c '
argv[1] = 'd'
argv[2] = 'e f'

This resolves a long-standing TODO comment.

Also, fixed a problem where multiple spaces between the module name and the first argument would result in argv[0] being set to an empty string.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net