src/sbbs3 writemsg.cpp 1.127 1.128
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2442

Modified Files:
writemsg.cpp
Log Message:
Addressed issue introduced in last commit:
File not found.
d:\sbbs\text\menu/msgtabs.asc


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.129 1.130
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Every get disconnected in the middle of writing a message (post or email)
and maybe lose all that eloquent prose you've painstakingly written? Well, Synchronet will now save your unsaved draft (assuming your editor saves it before exiting due to disconnetion) and will give you the option of
restoring that draft when you attempt to email or post again within 48
hours. The message's subject is saved/restored along with the draft body
text as well. Drafts older than 48 hours are just ignored. This duration
is currently hardcoded, but that could easily be changed.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/writemsg.cpp
By: rswindell to CVS commit on Thu Nov 08 2018 04:32 pm

writemsg.cpp
Log Message:
Every get disconnected in the middle of writing a message (post or email) and maybe lose all that eloquent prose you've painstakingly written? Well, Synchronet will now save your unsaved draft (assuming your editor saves it before exiting due to disconnetion) and will give you the option of restoring that draft when you attempt to email or post again within 48 hours. The message's subject is saved/restored along with the draft body text as well. Drafts older than 48 hours are just ignored. This duration is currently hardcoded, but that could easily be changed.

It sounds like the editor would need to support saving a user's message in order to enable this feature? Are there any details on how that is to be implemented in a message editor?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/writemsg.cpp
By: Nightfox to rswindell on Thu Nov 08 2018 05:18 pm

Re: src/sbbs3/writemsg.cpp
By: rswindell to CVS commit on Thu Nov 08 2018 04:32 pm

writemsg.cpp
Log Message:
Every get disconnected in the middle of writing a message (post or email) and maybe lose all that eloquent prose you've painstakingly written? Well, Synchronet will now save your unsaved draft (assuming your editor saves it before exiting due to disconnetion) and will give you the option of restoring that draft when you attempt to email or post again within 48 hours. The message's subject is saved/restored along with the draft body text as well. Drafts older than 48 hours are just ignored. This duration is currently hardcoded, but that could easily be changed.

It sounds like the editor would need to support saving a user's message in order to enable this feature? Are there any details on how that is to be implemented in a message editor?

The editor, if it detects disconnection, just needs to save the currently edited file before exiting (and returning a non-zero error level/exit code). fseditor.js just needed a minor tweak to support this. I'm not sure about all the other external editors out there.

digital man

Synchronet/BBS Terminology Definition #46:
NUL = ASCII 0
Norco, CA WX: 69.1øF, 10.0% humidity, 2 mph NE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.130 1.131
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18887

Modified Files:
writemsg.cpp
Log Message:
Store the draft message creation time stamp (just informational for now) and log a message when a draft message is saved.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.131 1.132
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3438

Modified Files:
writemsg.cpp
Log Message:
Don't save/restore 0-byte draft-messages.
More log output when saving/restoring drafts of if there is an error doing so.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Thu Nov 08 2018 06:02 pm

The editor, if it detects disconnection, just needs to save the currently edited file before exiting (and returning a non-zero error level/exit code). fseditor.js just needed a minor tweak to support this. I'm not sure about all the other external editors out there.

I'll have to see how fseditor.js is implementing it. Does this feature support multiple save files? For instance, in case a user logs on and starts replying to one message and gets disconnected, then logs in again and starts replying to a different message and gets disconnected. Or is it just whatever message got saved last?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/writemsg.cpp
By: Nightfox to Digital Man on Fri Nov 09 2018 10:02 am

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Thu Nov 08 2018 06:02 pm

The editor, if it detects disconnection, just needs to save the currently edited file before exiting (and returning a non-zero error level/exit code). fseditor.js just needed a minor tweak to support this. I'm not sure about all the other external editors out there.

I'll have to see how fseditor.js is implementing it.

This is pretty much it:

if(!bbs.online) {
save_file();
return 1; // aborted
}

Does this feature
support multiple save files? For instance, in case a user logs on and starts replying to one message and gets disconnected, then logs in again and starts replying to a different message and gets disconnected. Or is it just whatever message got saved last?

It'll save one draft per user per sub (or mail). I've contemplated even making the "to" name part of the saved-draft naming, but haven't gone that far. This is all invisible to the message editor (it just sees/edits the normal input.msg file or whatever).

digital man

Synchronet "Real Fact" #56:
Synchronet Terminal Server introduced SecureShell (SSH) support w/v3.14a (2006).
Norco, CA WX: 74.5øF, 6.0% humidity, 6 mph ENE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Fri Nov 09 2018 03:25 pm

It'll save one draft per user per sub (or mail). I've contemplated even making the "to" name part of the saved-draft naming, but haven't gone that far. This is all invisible to the message editor (it just sees/edits the normal input.msg file or whatever).

SlyEdit currently doesn't save on disconnection, so I'll have to make an update for it to do that when I have some time to do so.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/writemsg.cpp
By: Nightfox to Digital Man on Fri Nov 09 2018 05:09 pm

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Fri Nov 09 2018 03:25 pm

It'll save one draft per user per sub (or mail). I've contemplated even making the "to" name part of the saved-draft naming, but haven't gone that far. This is all invisible to the message editor (it just sees/edits the normal input.msg file or whatever).

SlyEdit currently doesn't save on disconnection, so I'll have to make an update for it to do that when I have some time to do so.

It seems most editors don't save changes on disconnect. Oh well,

digital man

This Is Spinal Tap quote #37:
David St. Hubbins: We are Spinal Tap from the UK - you must be the USA!
Norco, CA WX: 59.9øF, 15.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.132 1.133
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Always delete the quotes file (e.g. QUOTES.TXT) before deciding if we are
going to recover a draft message or quote a source message or whatever. Lingering QUOTES.TXT files interferred with recovering draft messages.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.133 1.134
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Fix the previous commit: the original message is quotes (and QUOTES.TXT created) before this funciton is called, so we can't *always* delete
the quote file. Delete it if restoring a draft or if quoting is disabled
only.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.135 1.136
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Remove trailing whitespace off the end of original messages when creating
quote files (ain't nobody got time for that!).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.136 1.137
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20423

Modified Files:
writemsg.cpp
Log Message:
Re-factored the internal text/message editor (msgeditor) to use the str_list_t data-type and API. This works better for terminals < 80 cols in width and has some other improvements with inserting/deleting lines using the arrow keys,
but still not great.
No longer does tab-expansion on text read from a file - may want to add that back in <shrug>.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.137 1.138
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Fixed GCC warning: format '%d' expects argument of type 'int', but argument 5 has type 'size_t'



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.138 1.139
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31805

Modified Files:
writemsg.cpp
Log Message:
Internal message editor needs to recount the lines when saving. This
is the likely cause of missing lines or "Aborted" messages upon saving
with the internal editor.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.139 1.140
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14967

Modified Files:
writemsg.cpp
Log Message:
Added support for the standard "Delete line" control keys (Ctrl-Y/X) to the
the internal message editor. It doesn't redraw the lines below the deleted
line or do anything terribly fancy, but at least it behaves more as one
would expect.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.147 1.148
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27853

Modified Files:
writemsg.cpp
Log Message:
Fix crash introduced in previous commit (rev 1.147) of this file (on Apr-16), when the user is using the internal msg editor (useron_xedit == 0) and
replying to a message.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.150 1.151
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28446

Modified Files:
writemsg.cpp
Log Message:
Use quote prefixes for auto-message body which allows us to word-wrap
nicely when displaying at various terminal widths.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.151 1.152
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Resolve GCC warning: enumeration value 'XEDIT_SOFT_CR_UNDEFINED' not handled
in switch



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.155 1.156
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23003

Modified Files:
writemsg.cpp
Log Message:
When the created message is UTF-8, translate (from CP-437 to UTF-8) any
user signature (.sig file) or editor created message tag (editor.tag file) contents before adding to message base.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.157 1.158
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6392

Modified Files:
writemsg.cpp
Log Message:
Use enum values from (new file) cp437defs.h



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.161 1.162
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Always check for the existence of RESULT.ED file after using an external
editor even if the editor was configured for QuickBBS/MSGINF drop files.
Don't use the subject line from RESULT.ED when the read-only subject mode
is used.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/writemsg.cpp
By: rswindell to CVS commit on Sat Jul 20 2019 12:06 pm

Modified Files:
writemsg.cpp
Log Message:
Always check for the existence of RESULT.ED file after using an external editor even if the editor was configured for QuickBBS/MSGINF drop files. Don't use the subject line from RESULT.ED when the read-only subject mode is used.

It looks like that works. Thanks!

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/writemsg.cpp
By: Nightfox to rswindell on Sun Jul 21 2019 11:21 am

Re: src/sbbs3/writemsg.cpp
By: rswindell to CVS commit on Sat Jul 20 2019 12:06 pm

Modified Files:
writemsg.cpp
Log Message:
Always check for the existence of RESULT.ED file after using an external editor even if the editor was configured for QuickBBS/MSGINF drop files. Don't use the subject line from RESULT.ED when the read-only subject mode is used.

It looks like that works. Thanks!

Cool. I see you added your version details to line 3 as well:

Editor SlyEdit 1.67 Beta (2019-07-19)

Nice!

digital man

Synchronet/BBS Terminology Definition #73:
Telenet = Proprietary packet switched network (variant on X.75)
Norco, CA WX: 66.6øF, 82.0% humidity, 4 mph SE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Mon Jul 22 2019 12:35 am

It looks like that works. Thanks!

Cool. I see you added your version details to line 3 as well:

Editor SlyEdit 1.67 Beta (2019-07-19)

Nice!

Yep, I figured I might as well have it write that too.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/writemsg.cpp
By: Nightfox to Digital Man on Mon Jul 22 2019 10:09 am

Re: src/sbbs3/writemsg.cpp
By: Digital Man to Nightfox on Mon Jul 22 2019 12:35 am

It looks like that works. Thanks!

Cool. I see you added your version details to line 3 as well:

Editor SlyEdit 1.67 Beta (2019-07-19)

Nice!

Yep, I figured I might as well have it write that too.

It's helpful when reporting issues or diagnosing problems. Appreciated.

digital man

Synchronet/BBS Terminology Definition #82:
XPDEV = Cross-platform Development
Norco, CA WX: 89.7øF, 43.0% humidity, 5 mph ESE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.163 1.164
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
writemsg.cpp
Log Message:
Address printf precision arg warning.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.164 1.165
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25255

Modified Files:
writemsg.cpp
Log Message:
We're storing the charset of locally created messages in the (new) SMB hfield: FIDOCHARSET, no longer FIDOCTRL.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.165 1.166
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24329

Modified Files:
writemsg.cpp
Log Message:
process_edited_text():
When message text contains an invalid or possibly dangerous Ctrl-A code, convert the Ctrl-A to an '@' char.
Only Ctrl-A *attribute* codes will be allowed in message text
(e.g. not ^AP, ^AL, ^A", etc.).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.166 1.167
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6418

Modified Files:
writemsg.cpp
Log Message:
Capture/use the "NOTE:" FTN-kludge added by external message editors.
Correctly support CR-terminated FTN-kludge lines (per spec, no LF is required). Save the revision of this source file as the editor details for raw (writemsg) and internal (msgeditor) created messages.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.167 1.168
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18198

Modified Files:
writemsg.cpp
Log Message:
Auto-detect ZMODEM upload of message text in internal line editor.
Discards any previously quoted/typed text, but remains in the editor with the uploaded text available for append or edit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.168 1.169
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8142

Modified Files:
writemsg.cpp
Log Message:
Add a /UPLOAD command which works with any/all configured protocols
(in addition to the auto-ZMODEM upload detection). Using an evil "goto" for code reuse.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 writemsg.cpp 1.170 1.171
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28822

Modified Files:
writemsg.cpp
Log Message:
Converted quoted UTF-8 message text and message subjects to CP437 for external editors that do not support UTF-8 (all of them, currently).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/eb209e8495db39e7732696fc
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Do not remove trailing white-space from lines in .sig files

This allows a .sig file to contain "\n-- \n", the "standard" USENET signature delimiter, as requested by Tracker1.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/97ac3bbf7720b3940d3f3198
Modified Files:
src/sbbs3/writemsg.cpp
Log Message:
Parse/separate forward-to-netmail name from address

Only do the local user notification when appropriate.
Signal the FTN netmail semaphore when appropriate.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net