• update doorscan to work with current synchronet

    From Rob Swindell@VERT to GitLab note in main/sbbs on Sunday, January 24, 2021 02:52:39
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1314

    Should get Deuce's approval since he wrote this.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Sunday, January 24, 2021 08:04:27
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1325

    Why?

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Sunday, January 24, 2021 08:04:27
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1324

    The user should not be notified of errors with doorscan... just the sysop.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Sunday, January 24, 2021 15:11:06
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1326

    that was actually a removal of existing code

    also the reason i removed that section is because doorscan always exists (in xtrn dir) so lbshell was always running doorscan, whether the sysop had setup doorscan or not. Now, if they want to optin to doorscan they can just add it to their modopts.ini (eval), or modify the pre/post external modules to launch it, and doorscan will load from any entry point (lbshell, other shells, xtrn_sec.js, rlogin, etc.)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Sunday, January 24, 2021 15:16:59
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1327

    i don't remember now why i did that, but there are only ever 2 params args we need (0 and 1), will never need more than that. first one is action, second one is external code. not that this would happen, but it does avoid issues if they were to pass the same argument multiple times (either because they didn't know what they were doing, or they actually had a door with an external code "scan", etc.)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 03:40:27
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1363

    Maybe the question from @Deuce is "Why check the length of `argv[0]`"?

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 07:56:34
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1366

    There's a lot of why there... why make command-line parsing more limited and harder to extend, why check the truthiness of argv[0] and arv[1] rather than checking if they exist, why hard-code argument numbers when it previously wasn't, etc.

    Previously, argv of ["run", "scan"] never executed the doScan() function as i was incremented when run was parsed.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 15:02:29
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1381

    reverted to prior handling of argv

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 15:02:40
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1382

    modified

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 19:04:24
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1388

    ```
    runPre(argv[++i].toLowerCase());
    ```
    You need to increment i when accessing it to avoid the argument being parsed in the next iteration of the loop.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 19:04:24
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1389

    Ditto

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 19:04:25
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1390

    For all these comparisons to undefined, you should use === and !== instead of == and !=

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 20:26:25
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1395

    most of these are prexisting, i just split that original method into a pre/post. i've updated the ones in my new functions but i'll leave all the ones throughout the file (preexisting) alone

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 20:26:35
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1396

    done

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 20:26:40
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1397

    done

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 21:00:08
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1398

    They should all be changed and the result tested. A decade ago when I wrote this, I wasn't aware of the existence of ===... it's almost always the correct thing to use.

    I'm willing to approve this as-is, but I strongly suggest if you keep working on it to go through and clean that issue up.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 21:07:12
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1400

    yeah i wasn't planning on doing anymore work on it right now...just contributing what i had to get it somewhat working again. i'm not using it at the moment

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 21:23:15
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1401

    One thing that's not clear... the title is "update doorscan to work with current synchronet" but there's no indication of how it previously didn't work. A message to that effect in the commit message (wherever that is) would be helpful.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 21:34:48
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1402

    can you even ammend a commit message after its been pushed? rob might be able to when he merges it. basically what i was trying to say is it is updated to work with the pre/post xtrn modules

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Michael Long@VERT to GitLab note in main/sbbs on Tuesday, January 26, 2021 21:35:45
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1403

    gitlab might use the title of the merge request when you merge it, i'll try that

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Tracker1@VERT/TRN to Michael Long on Thursday, January 28, 2021 00:30:10
    On 1/26/2021 2:34 PM, Michael Long wrote:
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/79#note_1402

    can you even ammend a commit message after its been pushed? rob
    might be able to when he merges it. basically what i was trying
    to say is it is updated to work with the pre/post xtrn modules

    git commit --amend
    git push --force

    NOTE: don't use force on master or release branches, but will use
    it on my working branches. Also:

    git rebase -i HEAD~##

    where ## is the number of commits to squash (PICK on first row S on
    others). Then:

    git pull --rebase upstream master

    is pretty useful as well...
    --
    Michael J. Ryan (tracker1)
    +o roughneckbbs.com

    ---
    Synchronet Roughneck BBS - roughneckbbs.com